Update to sinon 7 (Fixes: #261) #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to do And you should reference the issue in the PR description, and squash your patches into one. |
|
Hi, issue is referenced in the title |
|
The lock file still isn't right. Install the latest Node.js 12.x, and do |
|
Hi, I posted here my Debian patches [1 & 2] to help. Debian Node.js version is 10.16 and I don't want to update it. Feel free to accept or reject this PR. Cheers, [1]: sinon 7 |
|
First of all it's not my project either :) The thing is that your npm version generates quite different lock file. IMHO this shouldn't be merged unless the lock file is properly updated. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #261