Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sinon #261

Closed
cktang88 opened this issue Nov 21, 2019 · 3 comments · Fixed by #288
Closed

Update sinon #261

cktang88 opened this issue Nov 21, 2019 · 3 comments · Fixed by #288

Comments

@cktang88
Copy link

Currently uses sinon-restore, which hasn't been updated in 6 years, and depends on sinon 1.5.2. Sinon is currently on 7.5.0 which brings a lot of improvements/features
@XhmikosR
Copy link
Contributor

Feel free to submit a PR :)

guimard added a commit to guimard/node-coveralls that referenced this issue Dec 7, 2019
@guimard
Update to sinon 7 (Fixes: nickmerwin#261)
44b404c
@guimard
Copy link
Contributor

guimard commented Dec 7, 2019

PR submitted ;-)

@guimard
Copy link
Contributor

guimard commented Dec 7, 2019

And fixed (test passed)

guimard added a commit to guimard/node-coveralls that referenced this issue Dec 7, 2019
@guimard
Update to sinon 7 (Fixes: nickmerwin#261)
bd20fc6
@guimard guimard mentioned this issue Dec 7, 2019
Closed
@XhmikosR XhmikosR mentioned this issue Apr 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update sinon to v7.5.0.
Update to sinon 7 (Fixes: #261) guimard/node-coveralls
3 participants
@guimard @XhmikosR @cktang88