Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Functional Tests for Internationalization #525

Merged

Conversation

charitylxy
Copy link
Collaborator

@charitylxy charitylxy commented Mar 4, 2024

What does this Pull Request accomplish?

Add test coverage to support internationalization for user provided strings (Implemented in #518)

Why should this Pull Request be merged?

  • Internationalization tests for user provided strings covered in the following languages:
    • German
    • French
    • Japanese
    • Korean
    • Chinese

What testing has been done?

PS C:\dev\nidaqmx-python> poetry run pytest -k test_internationalization
========================================================================================= test session starts ==========================================================================================
platform win32 -- Python 3.9.13, pytest-8.0.2, pluggy-1.4.0
rootdir: C:\dev\nidaqmx-python
configfile: pyproject.toml
testpaths: tests
plugins: cov-4.1.0, mock-3.12.0
collected 1887 items / 1867 deselected / 20 selected

tests\acceptance\test_internationalization.py .....sssss.....sssss                                                                                                                                [100%]

=========================================================================== 10 passed, 10 skipped, 1867 deselected in 1.17s ============================================================================  

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this is a draft but I have some early feedback.

tests/component/test_internalization.py Outdated Show resolved Hide resolved
tests/component/test_internalization.py Outdated Show resolved Hide resolved
tests/component/test_internalization.py Outdated Show resolved Hide resolved
tests/component/test_internalization.py Outdated Show resolved Hide resolved
tests/component/test_internalization.py Outdated Show resolved Hide resolved
@charitylxy charitylxy changed the title Add Functional Tests for Internalization Add Functional Tests for Internationalization Mar 5, 2024
@charitylxy charitylxy marked this pull request as ready for review March 5, 2024 04:51
@charitylxy charitylxy requested a review from bkeryan March 5, 2024 04:51
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

tests/acceptance/test_internationalization.py Show resolved Hide resolved
tests/acceptance/test_internationalization.py Outdated Show resolved Hide resolved
tests/acceptance/test_internationalization.py Show resolved Hide resolved
tests/acceptance/test_internationalization.py Outdated Show resolved Hide resolved
@charitylxy charitylxy merged commit bac7f01 into ni:master Mar 6, 2024
16 checks passed
@charitylxy charitylxy deleted the users/charitylxy/internalization-tests branch March 7, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants