-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Non-ASCII Characters for User-Provided String #518
Support Non-ASCII Characters for User-Provided String #518
Conversation
Not sure if it's appropriate to still load |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this PR looks good but the rename to .env.sample
slipped through the cracks. We should also document it as if it is a sample. Hopefully this will be the last round of changes.
76d36cb
to
f2ea31d
Compare
What does this Pull Request accomplish?
This PR aims to address the issue brought up in #384 and #384
Why should this Pull Request be merged?
What testing has been done?
Manually tested on command line with non ASCII string argument.