Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: Update DAQmx and MI examples to use new session management API #442

Merged
merged 8 commits into from
Oct 13, 2023
Merged

examples: Update DAQmx and MI examples to use new session management API #442

merged 8 commits into from
Oct 13, 2023

Conversation

bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Oct 13, 2023 •
edited
Loading

What does this Pull Request accomplish?

Update DAQmx and MI examples to use the new session management API.

Note
The new session management API is behind a feature toggle. To enable it, add MEASUREMENTLINK_ALLOW_INCOMPLETE=1 or MEASUREMENTLINK_ENABLE_SESSION_MANAGEMENT_2024Q1=1 to a file named .env, located in your service directory or one of its parent directories.

Refactor MI cancellation code:

  • Extract into a helper function.
  • Attempt to be more consistent about handling user timeouts vs. gRPC deadlines.

Add more comments explaining the program flow and mapping between pins/sites and channels.

Why should this Pull Request be merged?

Partially addresses AB#2527580

I will post a separate PR for nivisa_dmm_measurement and output_voltage_measurement. They both need to be updated for #439 first.

What testing has been done?

Ran all affected examples with simulation enabled via .env.

@github-actions
Copy link

github-actions bot commented Oct 13, 2023 •
edited
Loading

Test Results

       30 files  ±0       30 suites  ±0   26m 22s ⏱️ +55s
     452 tests ±0     376 ✔️ ±0       76 💤 ±0  0 ❌ ±0 
13 530 runs  ±0  9 650 ✔️ ±0  3 880 💤 ±0  0 ❌ ±0 

Results for commit 8b730c3. ± Comparison against base commit 16a5ecb.

♻️ This comment has been updated with latest results.

@bkeryan bkeryan mentioned this pull request Oct 13, 2023
Closed
1 task
@bkeryan bkeryan merged commit 8a05e88 into main Oct 13, 2023
20 checks passed
@bkeryan bkeryan deleted the users/bkeryan/update-examples branch October 13, 2023 15:48
@bkeryan bkeryan mentioned this pull request Oct 13, 2023
Closed
@bkeryan bkeryan linked an issue Oct 13, 2023 that may be closed by this pull request
use_simulation_option cmd line option in examples has no effect #395
Closed
@bkeryan bkeryan mentioned this pull request Apr 15, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixonjoel dixonjoel dixonjoel approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@pbirkhol-ni pbirkhol-ni Awaiting requested review from pbirkhol-ni

@mshafer-NI mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

@nstokes-nati nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use_simulation_option cmd line option in examples has no effect
2 participants
@bkeryan @dixonjoel