Create visa_dmm custom driver and updated nivisa_dmm_measurement #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avinash2Suresh
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan,
nstokes-nati and
mshafer-NI
as code owners
vigkre
approved these changes
Oct 11, 2023
keer1111
approved these changes
Oct 11, 2023
Avinash2Suresh
changed the title
bkeryan
requested changes
Oct 12, 2023
bkeryan
reviewed
Oct 12, 2023
bkeryan
reviewed
Oct 12, 2023
bkeryan
reviewed
Oct 12, 2023
bkeryan
requested changes
Oct 12, 2023
bkeryan
reviewed
Oct 12, 2023
bkeryan
approved these changes
Oct 12, 2023
1 task
dixonjoel
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Refactored the VISA examples to use
_visa_dmm.pycustom instrument driver instead of directly manipulating VISA sessions in_visa_helpers.py.Updated the
nivisa_dmm_measurementexamples to use the newly created_visa_dmm.pydriver.Why should this Pull Request be merged?
Part of the new session management API.
Implement - Task 2542508: Create _visa_dmm.py driver and update NI_VISA_DMM example
What testing has been done?
Manually tested with the updated
nivisa_dmm_measurementin both InstrumentStudio and TestStand.