Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting enum values and maintaining backward compatability #1049

Merged
merged 1 commit into from
Mar 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions generated/nirfmxspecan/nirfmxspecan.proto
Original file line number Diff line number Diff line change
Expand Up @@ -5350,12 +5350,12 @@ message IDPDCfgReferenceWaveformRequest {
double dx = 4;
repeated nidevice_grpc.NIComplexNumberF32 reference_waveform = 5;
oneof idle_duration_present_enum {
IdpdReferenceWaveformIdleDurationPresent idle_duration_present = 6;
int32 idle_duration_present_raw = 7;
int32 idle_duration_present_raw = 6;
reckenro marked this conversation as resolved.
Show resolved Hide resolved
IdpdReferenceWaveformIdleDurationPresent idle_duration_present = 8;
}
oneof signal_type_enum {
IdpdSignalType signal_type = 8;
int32 signal_type_raw = 9;
int32 signal_type_raw = 7;
IdpdSignalType signal_type = 9;
}
}

Expand Down
24 changes: 24 additions & 0 deletions source/codegen/metadata/nirfmxlte/functions_addon.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,26 @@
functions_override_metadata = {
'CfgPSSCHModulationType': {
'parameters': [
{
'direction': 'in',
'grpc_name': 'instrument',
'name': 'instrumentHandle',
'type': 'niRFmxInstrHandle'
},
{
'direction': 'in',
'name': 'selectorString',
'type': 'char[]'
},
{
'direction': 'in',
'enum': 'PsschModulationType',
'grpc_field_number': '4',
'grpc_raw_field_number': '3',
'name': 'modulationType',
'type': 'int32'
}
],
'returns': 'int32'
},
}
4 changes: 4 additions & 0 deletions source/codegen/metadata/nirfmxspecan/functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -6628,12 +6628,16 @@
{
'direction': 'in',
'enum': 'IdpdReferenceWaveformIdleDurationPresent',
'grpc_raw_field_number': '6',
'grpc_field_number': '8',
'name': 'idleDurationPresent',
'type': 'int32'
},
{
'direction': 'in',
'enum': 'IdpdSignalType',
'grpc_raw_field_number': '7',
'grpc_field_number': '9',
'name': 'signalType',
'type': 'int32'
}
Expand Down
56 changes: 56 additions & 0 deletions source/codegen/metadata/nirfmxspecan/functions_addon.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,58 @@
functions_override_metadata = {
'IDPDCfgReferenceWaveform': {
'parameters': [
{
'direction': 'in',
'grpc_name': 'instrument',
'name': 'instrumentHandle',
'type': 'niRFmxInstrHandle'
},
{
'direction': 'in',
'name': 'selectorString',
'type': 'char[]'
},
{
'direction': 'in',
'name': 'x0',
'type': 'float64'
},
{
'direction': 'in',
'name': 'dx',
'type': 'float64'
},
{
'direction': 'in',
'name': 'referenceWaveform',
'size': {
'mechanism': 'len',
'value': 'arraySize'
},
'type': 'NIComplexSingle[]'
},
{
'direction': 'in',
'name': 'arraySize',
'type': 'int32'
},
{
'direction': 'in',
'enum': 'IdpdReferenceWaveformIdleDurationPresent',
'grpc_raw_field_number': '6',
'grpc_field_number': '8',
'name': 'idleDurationPresent',
'type': 'int32'
},
{
'direction': 'in',
'enum': 'IdpdSignalType',
'grpc_raw_field_number': '7',
'grpc_field_number': '9',
'name': 'signalType',
'type': 'int32'
}
],
'returns': 'int32'
},
}
Loading