Correcting enum values and maintaining backward compatability #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulBenaka
requested review from
reckenro,
astarche and
maxxboehme
as code owners
|
@reckenro @astarche @maxxboehme Please review the PR as we have to merge this asap. This is required for the release in both gRPC and RFmx 24.3.0 products FYI: @ThangamV-NI |
reckenro
reviewed
Mar 21, 2024
reckenro
approved these changes
Mar 21, 2024
astarche
approved these changes
Mar 21, 2024
maxxboehme
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Avoids changing a field number in the RFmx LTE Proto from the previous release.
Avoids changing a field number in the RFmxSpecAn Proto from the previous release
Why should this Pull Request be merged?
Reverses the binary breaking change introduced in #1047
Adding the special implementation in the functions_addon.py files of SpecAn and LTE to make sure correct code is generated in future.
What testing has been done?
The build.