Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove orphan pages #134

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Remove orphan pages #134

merged 2 commits into from
Nov 19, 2024

Conversation

vickytnz
Copy link
Contributor

@vickytnz vickytnz commented Nov 19, 2024 •
edited
Loading

Remove:

  • 5 base pages from the tutorial (oops this was me)
  • 2 old install pages that aren't used anywhere

I want to do some rearranging (for example moving the parent pages that are used for both the windows and mac install pages) but this will be done in a separate ticket

@vickytnz
Remove orphan pages
49bd00c 
Remove:

* 5 base pages from the tutorial (oops this was me)
* 2 old install pages that aren't used anywhere
@vickytnz vickytnz linked an issue Nov 19, 2024 that may be closed by this pull request
Orphan pages in the install guide #133
Closed
frankieroberto
frankieroberto approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like app/views/install/windows/git-bash.html is orphaned and could be deleted too?

Possibly it is worth considering recommending GitBash for Windows users, but I guess it’s another thing to install, and not all Windows users may be able to?

@vickytnz
Copy link
Contributor Author

Ah looks like you and Ananda were right.
The GOV.UK guide uses Gitbash as it makes it consistent for everyone, however given that the page is abandoned for now (even the old version doesn't have it) I'm going to remove for now as if it doesn't work we can just update the entire install guide.

@vickytnz vickytnz merged commit e35e58a into main Nov 19, 2024
4 checks passed
@vickytnz vickytnz deleted the 133-remove-orphan-pages-in-the-install-guide branch November 19, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankieroberto frankieroberto frankieroberto approved these changes

@anandamaryon1 anandamaryon1 Awaiting requested review from anandamaryon1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orphan pages in the install guide
2 participants
@vickytnz @frankieroberto