Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphan pages in the install guide #133

Closed
vickytnz opened this issue Nov 19, 2024 · 3 comments · Fixed by #134
Closed

Orphan pages in the install guide #133

vickytnz opened this issue Nov 19, 2024 · 3 comments · Fixed by #134
Labels
Content Improvements or additions to documentation

Comments

@vickytnz
Copy link
Contributor

While looking at pages, I found 2 pages that do not seem to be used and both of which I think we should delete:

1. Requirements

This is on https://prototype-kit.service-manual.nhs.uk/install/requirements

requirements page

There are versions like this in the GOV.UK Prototype Kit for windows, mac, and linux.

2. Where to keep prototypes

This is on https://prototype-kit.service-manual.nhs.uk/install/where-to-keep

page of where to keep prototypes

There is nothing similar in the GOV.UK Prototype Kit.

@vickytnz vickytnz added the Content Improvements or additions to documentation label Nov 19, 2024
@anandamaryon1
Copy link
Contributor

Yep looks like they can be removed, good find 👍

Taking a look at them I found this one too: https://prototype-kit.service-manual.nhs.uk/install/windows/git-bash
image

And this one too: https://prototype-kit.service-manual.nhs.uk/install/download
image

@anandamaryon1
Copy link
Contributor

anandamaryon1 commented Nov 19, 2024

In fact, maybe all the guide pages in /install that are duplicated in /install/mac and /install/windows?

@vickytnz
Copy link
Contributor Author

All of the windows and mac install pages use a shared parent page that lives on the /install/ folder and is mostly the same but with some blocks that the child pages have content on, for example :

  • /install/download is used as a parent page for both /install/mac/download and /install/windows/download with the parent page having some blocks that are then filled in on the child pages.

I hadn't touched them since in a way it makes sense to have some reusable code, but the particular setup now makes it a pain - at the least I think I'll move all of the shared install base pages into an /includes folder and update the links to make sure we've got better visibility of all of the pages but will wait until after Sara has done the content review just in case it includes these pages.

@vickytnz vickytnz linked a pull request Nov 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Improvements or additions to documentation
Development

Successfully merging a pull request may close this issue.

2 participants