Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRMP-1330] - Add service-updates-link to footer #491

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[PRMP-1330] - Add service-updates-link to footer #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08e58f2
[PRMP-1330] - Add service-updates-link to footer
MohammadIqbalAD-NHS Dec 17, 2024
9eabba8
[PRMP-1330] - Remove brackets in aria-label for screen readers
MohammadIqbalAD-NHS Dec 18, 2024
e23cdd1
[PRMP-1330] - Add test for rendering service-updates-link
MohammadIqbalAD-NHS Dec 19, 2024
7bdb72b
[PRMP-1330] - Modify footer to use constant instead of react component
MohammadIqbalAD-NHS Dec 20, 2024
b887be9
[PRMP-1330] - Undo privacy-link modification
MohammadIqbalAD-NHS Dec 20, 2024
f9f8404
Merge branch 'main' into PRMP-1330
MohammadIqbalAD-NHS Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/src/components/layout/footer/Footer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ describe('Footer', () => {
render(<Footer />);
expect(screen.getByTestId('privacy-link')).toBeInTheDocument();
});
it('renders service updates link', () => {
render(<Footer />);
expect(screen.getByTestId('service-updates-link')).toBeInTheDocument();
});
});

describe('Navigation', () => {
Expand Down
14 changes: 13 additions & 1 deletion app/src/components/layout/footer/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import React from 'react';
import { Footer as NHSFooter } from 'nhsuk-react-components';
import { routes } from '../../../types/generic/routes';

const serviceUpdatesLink =
'https://digital.nhs.uk/services/access-and-store-digital-patient-documents/service-updates';

function Footer() {
return (
<NHSFooter>
Expand All @@ -11,10 +14,19 @@ function Footer() {
data-testid="privacy-link"
rel="opener"
target="_blank"
aria-label="(Privacy notice - this link will open in a new tab)"
aria-label="Privacy notice - Opens in a new tab"
>
Privacy notice
</NHSFooter.ListItem>
<NHSFooter.ListItem
href={serviceUpdatesLink}
data-testid="service-updates-link"
rel="noopener"
target="_blank"
aria-label="Service updates - Opens in a new tab"
>
Service updates
</NHSFooter.ListItem>
</NHSFooter.List>
{/* TODO - PRMP-1348: Remove hardcoded styling below if no longer required */}
<NHSFooter.Copyright style={{ color: '#231f20' }}>
Expand Down
Loading