[PRMP-1330] - Add service-updates-link to footer #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverbeumkes-nhs
previously approved these changes
Dec 17, 2024
oliverbeumkes-nhs
dismissed
their stale review
I didn't realise this was a draft
app/src/components/generic/serviceUpdatesLink/ServiceUpdatesLink.tsx
Outdated
Show resolved
Hide resolved
steph-torres-nhs
approved these changes
Dec 18, 2024
abid-nhs
requested changes
Dec 18, 2024
| @@ -15,6 +16,7 @@ function Footer() { | |||
| > | |||
| Privacy notice | |||
| </NHSFooter.ListItem> | |||
| <ServiceUpdatesLink /> | |||
There was a problem hiding this comment.
As discussed I was wondering if it would be worth making the <NHSFooter.ListItem for ServiceUpdatesLink in the same file rather than separate one like the privacy link Footer list item. This might help with consistency especially since the ServiceUpdatesLink might not be usable in other places as its made as a NHSFooter.listitem
There was a problem hiding this comment.
I have modified this to no longer use a component but rather a constant within the Footer.tsx
abid-nhs
approved these changes
Dec 20, 2024
abid-nhs
requested changes
Dec 20, 2024
abid-nhs
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.