Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(data): clarify entity dispatcher fires action once #4005

Merged
merged 2 commits into from
Aug 14, 2023
Merged

docs(data): clarify entity dispatcher fires action once #4005

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78daa40
docs(data): clarify entity dispatcher fires action once
Nosfistis Aug 14, 2023
70a31e5
Apply suggestions from code review
Nosfistis Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion projects/ngrx.io/content/guide/data/entity-collection-service.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,10 @@ An entity argument **must never be a cached entity object**.
It can be a _copy_ of a cached entity object and it often is.
The demo application always calls these command methods with copies of the entity data.

All _command methods_ return `void`.
All _command methods_ return `void` or an `Observable`.
A core principle of the _redux pattern_ is that _commands_ never return a value. They just _do things_ that have side-effects.
Thus, the action is only dispatched when the command is invoked, and re-subscribing to a command's returned `Observable` will not
dispatch another action.

Rather than expect a result from the command,
you subscribe to a _selector$_ property that reflects
Expand Down