Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(data): clarify entity dispatcher fires action once #4005

Merged
merged 2 commits into from
Aug 14, 2023
Merged

docs(data): clarify entity dispatcher fires action once #4005

merged 2 commits into from
Aug 14, 2023

Conversation

Nosfistis
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3979

What is the new behavior?

Mention that re-subscribing to an EntityCollectionService command
does not create a new action, even though some commands return
an Observable with the result.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Mention that re-subscribing to an `EntityCollectionService` command
does not create a new action, even though some commands return
an `Observable` with the result.

Closes #3979
@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 70a31e5
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/64da2c646adfd700083100b6
😎 Deploy Preview https://deploy-preview-4005--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nosfistis
Copy link
Contributor Author

I applied the changes. Should I also squash the commits?

@brandonroberts
Copy link
Member

I applied the changes. Should I also squash the commits?

You can, but you don't have to. We'll squash them on merge either way

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @Nosfistis

@brandonroberts brandonroberts merged commit 7716e46 into ngrx:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity dispatchers do not re-dispatch action on re-subscribe
3 participants