Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): make DataServiceError extend from Error #3988

Merged
merged 1 commit into from
Aug 5, 2023
Merged

fix(data): make DataServiceError extend from Error #3988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions modules/data/src/dataservices/data-service-error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@ import { RequestData } from './interfaces';
* @param error the HttpErrorResponse or the error thrown by the service
* @param requestData the HTTP request information such as the method and the url.
*/
// If extend from Error, `dse instanceof DataServiceError` returns false
// in some (all?) unit tests so don't bother trying.
export class DataServiceError {
message: string | null;

export class DataServiceError extends Error {
constructor(public error: any, public requestData: RequestData | null) {
this.message = typeof error === 'string' ? error : extractMessage(error);
super(
typeof error === 'string' ? error : extractMessage(error) ?? undefined
);
this.name = this.constructor.name;
}
}

Expand Down