fix(data): make DataServiceError extend from Error #3988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was kind of surprised when
DataServiceError instanceof Error
returnedfalse
but then I saw the note in the source code (4 years ago) about howdse instanceof DataServiceError
didn't work in unit tests when extending fromError
. As long assuper()
is called in the child class constructor when extending fromError
, theninstanceof
should work fine. I made the change, then ran the unit tests and they all passed so it seems it's ok.This is not a big deal but it's usually good form to have
Error
in the inheritance chain of custom errors. I don't believe this is a breaking change.