Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed example in reducers.md #2247

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Fixed example in reducers.md #2247

merged 1 commit into from
Nov 12, 2019

Conversation

acb14js
Copy link
Contributor

@acb14js acb14js commented Nov 12, 2019

Code change related to this issue: #2233

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

#2233

import { createAction } from '@ngrx/store';

Closes #2233

What is the new behavior?

import { createAction, props } from '@ngrx/store';

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Code change related to this issue: ngrx#2233
@ngrxbot
Copy link
Collaborator

ngrxbot commented Nov 12, 2019

Preview docs changes for 94abc55 at https://previews.ngrx.io/pr2247-94abc55/

@brandonroberts brandonroberts merged commit 1343dff into ngrx:master Nov 12, 2019
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Missing "props" import on scoreboard-page.actions.ts example
3 participants