Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Missing "props" import on scoreboard-page.actions.ts example #2233

Closed
acb14js opened this issue Nov 8, 2019 · 7 comments · Fixed by #2247
Closed

Docs: Missing "props" import on scoreboard-page.actions.ts example #2233

acb14js opened this issue Nov 8, 2019 · 7 comments · Fixed by #2247
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs Good First Issue Good issue for first-time contributor

Comments

@acb14js
Copy link
Contributor

acb14js commented Nov 8, 2019

I think there is a missing import in the scoreboard-page.actions.ts example from the Reducers tutorial page (https://ngrx.io/guide/store/reducers)

I think the imports should change from:

import { createAction } from '@ngrx/store';
To this:
import { createAction, props } from '@ngrx/store';

Because the props method is used on the line
export const setScores = createAction('[Scoreboard Page] Set Scores', props<{game: Game}>());

@timdeschryver
Copy link
Member

You're totally right @abinp !

Feel free to create a PR with the proposed change 👍

@timdeschryver timdeschryver added Accepting PRs Comp: Docs Good First Issue Good issue for first-time contributor labels Nov 8, 2019
@jordanpowell88
Copy link
Contributor

If @acb14js doesn't want to I can

@timdeschryver
Copy link
Member

Let's give @acb14js the time to answer @jordanpowell88

acb14js added a commit to acb14js/platform that referenced this issue Nov 12, 2019
Code change related to this issue: ngrx#2233
@acb14js
Copy link
Contributor Author

acb14js commented Nov 12, 2019

@timdeschryver just added the pull request

@timdeschryver
Copy link
Member

@acb14js I think you still have to create the pull request at https://github.com/ngrx/platform/pulls by clicking on "New pull request" (green button at the top right).

@acb14js
Copy link
Contributor Author

acb14js commented Nov 12, 2019

@timdeschryver Thanks for your patience, Its my first time creating a pull request. I think I've setup the pull request correctly now.

@timdeschryver
Copy link
Member

Super! Thanks @acb14js

@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label Nov 12, 2019
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this issue Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs Good First Issue Good issue for first-time contributor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants