-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Missing "props" import on scoreboard-page.actions.ts example #2233
Comments
You're totally right @abinp ! Feel free to create a PR with the proposed change 👍 |
If @acb14js doesn't want to I can |
Let's give @acb14js the time to answer @jordanpowell88 |
Code change related to this issue: ngrx#2233
@timdeschryver just added the pull request |
@acb14js I think you still have to create the pull request at https://github.com/ngrx/platform/pulls by clicking on "New pull request" (green button at the top right). |
@timdeschryver Thanks for your patience, Its my first time creating a pull request. I think I've setup the pull request correctly now. |
Super! Thanks @acb14js |
I think there is a missing import in the scoreboard-page.actions.ts example from the Reducers tutorial page (https://ngrx.io/guide/store/reducers)
I think the imports should change from:
import { createAction } from '@ngrx/store';
To this:
import { createAction, props } from '@ngrx/store';
Because the props method is used on the line
export const setScores = createAction('[Scoreboard Page] Set Scores', props<{game: Game}>());
The text was updated successfully, but these errors were encountered: