Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router-store) Add base router selectors #1874

Merged
merged 17 commits into from
May 29, 2019
Merged

feat(router-store) Add base router selectors #1874

merged 17 commits into from
May 29, 2019

Conversation

jasonhodges
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
Adds base set of selectors for Router Store

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #
#1854

What is the new behavior?

Exposes base set of selectors user may use in reducer, similar to the ones of Entity

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Jason Hodges and others added 2 commits May 16, 2019 16:45
feat(router-store) Add base router selectors
4ac2170
@jasonhodges
feat(router-store) Add base router selectors
b3af493 
- create initial spec
- tested selectors retrievable from example app
@jasonhodges jasonhodges changed the title Pr/router store selectors feat(router-store) Add base router selectors May 18, 2019
@ngrxbot
Copy link
Collaborator

ngrxbot commented May 18, 2019

Preview docs changes for b3af493 at https://previews.ngrx.io/pr1874-b3af493/

@jasonhodges
feat(router-store) Add base router selectors
c3fa700 
- test remaining selectors
- update mock data
- tested selectors retrievable from example app
- add routeTraverse helper function for shared functionality
@ngrxbot
Copy link
Collaborator

ngrxbot commented May 21, 2019

Preview docs changes for c3fa700 at https://previews.ngrx.io/pr1874-c3fa700/

@brandonroberts brandonroberts added the WIP Not ready for review label May 21, 2019
@jasonhodges
feat(router-store) Add base router selectors
7c37ccd 
- utilize createSelectors() internally
@ngrxbot
Copy link
Collaborator

ngrxbot commented May 23, 2019

Preview docs changes for 7c37ccd at https://previews.ngrx.io/pr1874-7c37ccd/

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 24, 2019

Preview docs changes for c0e82bf at https://previews.ngrx.io/pr1874-c0e82bf/

@jasonhodges jasonhodges force-pushed the pr/router-store-selectors branch from 0e1ef39 to 04583bb Compare May 24, 2019 15:15
@ngrxbot
Copy link
Collaborator

ngrxbot commented May 24, 2019

Preview docs changes for 0e1ef39 at https://previews.ngrx.io/pr1874-0e1ef39/

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 24, 2019

Preview docs changes for 04583bb at https://previews.ngrx.io/pr1874-04583bb/

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 24, 2019

Preview docs changes for a276b48 at https://previews.ngrx.io/pr1874-a276b48/

@jasonhodges
feat(router-store) Add base router selectors
b512528 
- add Router selectors documentation
@jasonhodges jasonhodges marked this pull request as ready for review May 26, 2019 14:13
@ngrxbot
Copy link
Collaborator

ngrxbot commented May 26, 2019

Preview docs changes for b512528 at https://previews.ngrx.io/pr1874-b512528/

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 26, 2019

Preview docs changes for face309 at https://previews.ngrx.io/pr1874-face309/

@jasonhodges
feat(router-store) Add base router selectors
fc8fee9 
- put documentation in correct location
@jasonhodges
feat(router-store) Add base router selectors
a8d9738 
- remove check for selectState since required
@ngrxbot
Copy link
Collaborator

ngrxbot commented May 28, 2019

Preview docs changes for a8d9738 at https://previews.ngrx.io/pr1874-a8d9738/

@brandonroberts brandonroberts removed the WIP Not ready for review label May 29, 2019
brandonroberts
brandonroberts requested changes May 29, 2019
View reviewed changes
projects/ngrx.io/content/guide/router-store/selectors.md Outdated Show resolved Hide resolved
projects/ngrx.io/content/guide/router-store/selectors.md Outdated Show resolved Hide resolved
projects/ngrx.io/content/guide/router-store/selectors.md Outdated Show resolved Hide resolved
projects/ngrx.io/content/navigation.json Outdated Show resolved Hide resolved
modules/router-store/spec/router_selectors.spec.ts Outdated Show resolved Hide resolved
@brandonroberts
Copy link
Member

@jasonhodges We also need to mention in the docs that this works with the built in reducer provider by @ngrx/router-store. If you use your own custom serializer, you'll need to provide your own selectors if they do not adhere to the same shape.

@jasonhodges
feat(router-store) Add base router selectors
e354684 
- update documentation based off review
@ngrxbot
Copy link
Collaborator

ngrxbot commented May 29, 2019

Preview docs changes for e354684 at https://previews.ngrx.io/pr1874-e354684/

@jasonhodges
feat(router-store) Add base router selectors
3abcc7d 
- link out to custom serializer
@ngrxbot
Copy link
Collaborator

ngrxbot commented May 29, 2019

Preview docs changes for 3abcc7d at https://previews.ngrx.io/pr1874-3abcc7d/

@jasonhodges
feat(router-store) Add base router selectors
3acc6dd 
- remove unnecessary type from model
- add additional unit tests
- correct documentation wording
@ngrxbot
Copy link
Collaborator

ngrxbot commented May 29, 2019

Preview docs changes for 3acc6dd at https://previews.ngrx.io/pr1874-3acc6dd/

@jasonhodges
feat(router-store) Add base router selectors
729093b 
- remove left over commented code
@ngrxbot
Copy link
Collaborator

ngrxbot commented May 29, 2019

Preview docs changes for 729093b at https://previews.ngrx.io/pr1874-729093b/

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 29, 2019

Preview docs changes for 5a27f45 at https://previews.ngrx.io/pr1874-5a27f45/

@brandonroberts brandonroberts merged commit 21c67cc into ngrx:master May 29, 2019
@brandonroberts
Copy link
Member

Thanks @jasonhodges!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver left review comments

@yngvebn yngvebn yngvebn left review comments

@ThomasBurleson ThomasBurleson ThomasBurleson left review comments

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasonhodges @ngrxbot @brandonroberts @ThomasBurleson @yngvebn @timdeschryver