Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router Store: Expose some selectors for selecting router info #1854

Closed
brandonroberts opened this issue May 14, 2019 · 3 comments
Closed

Router Store: Expose some selectors for selecting router info #1854

brandonroberts opened this issue May 14, 2019 · 3 comments
Labels
Accepting PRs community watch Someone from the community is working this issue/PR enhancement Project: Router Store

Comments

@brandonroberts
Copy link
Member

We already have a reducer to add router state on navigations, but don't provide any selectors to get the data out. We should provide a minimum set of selectors out of the box to get:

  • query params
  • route params
  • route data
  • url

The initial idea is that this would be a function that returns selectors for the items mentioned above, similar to getSelectors() in Entity.

@jtcrowson
Copy link
Contributor

jtcrowson commented May 14, 2019

I can take it Actually, I may not have time this week, but I'm interested if no one else picks it up.

@santoshyadavdev
Copy link
Contributor

Hi @jtcrowson ,
Should I take it, I am done with my existing PRs.

@brandonroberts
Copy link
Member Author

@jasonhodges is working this one already

@brandonroberts brandonroberts added the community watch Someone from the community is working this issue/PR label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR enhancement Project: Router Store
Projects
None yet
Development

No branches or pull requests

3 participants