Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data): add schematics and migrations #1782

Merged
merged 7 commits into from
Apr 23, 2019
Merged

feat(data): add schematics and migrations #1782

merged 7 commits into from
Apr 23, 2019

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Apr 22, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Related to #1554

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The flag migrate is to rename keywords as in #1780, it will also uninstall ngrx-data.

@timdeschryver timdeschryver mentioned this pull request Apr 22, 2019
Merged
3 tasks
brandonroberts
brandonroberts requested changes Apr 23, 2019
View reviewed changes
modules/data/schematics/ng-add/schema.json Outdated
"title": "NgRx Data Schema",
"type": "object",
"properties": {
"withoutEffects": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to effects and default to true

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 23, 2019

Preview docs changes for 28628e0 at https://previews.ngrx.io/pr1782-28628e0/

@brandonroberts brandonroberts merged commit c79362d into master Apr 23, 2019
@brandonroberts brandonroberts deleted the pr/data-migrations branch April 23, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timdeschryver @ngrxbot @brandonroberts