Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(data): rename NgRxDataModule to EntityDataModule #1780

Merged
merged 4 commits into from
Apr 22, 2019

Conversation

jtcrowson
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1777

What is the new behavior?

To stay consistent across modules, the following was renamed:

NgrxDataModule -> EntityDataModule
NgrxDataModuleWithoutEffects -> EntityDataModuleWithoutEffects
NgrxDataModuleConfig -> EntityDataModuleConfig

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 22, 2019

Preview docs changes for cce25fb at https://previews.ngrx.io/pr1780-cce25fb/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also rename ngrx-data.module.spec please?

@jtcrowson
Copy link
Contributor Author

@timdeschryver renamed in b03eb87.

@brandonroberts
Copy link
Member

#1767 is merged now, so you'll need to rebase on master and update the overview page also.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 22, 2019

Preview docs changes for b03eb87 at https://previews.ngrx.io/pr1780-b03eb87/

@jtcrowson jtcrowson force-pushed the data-rename-to-EntityDataModule branch from b03eb87 to 7500dc0 Compare April 22, 2019 15:29
@jtcrowson
Copy link
Contributor Author

jtcrowson commented Apr 22, 2019

@brandonroberts rebased. Updated data overview page to reflect code renaming in 7500dc0. Should I update the term "NgRx Data" to "Entity Data" on the overview page as well?

@brandonroberts
Copy link
Member

We still want to refer to it as NgRx Data, with EntityData for usage

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 22, 2019

Preview docs changes for 7500dc0 at https://previews.ngrx.io/pr1780-7500dc0/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brandonroberts brandonroberts merged commit 4c850b5 into ngrx:master Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data: rename NgRxDataModule to EntityDataModule
4 participants