-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(data): rename NgRxDataModule to EntityDataModule #1780
refactor(data): rename NgRxDataModule to EntityDataModule #1780
Conversation
Preview docs changes for cce25fb at https://previews.ngrx.io/pr1780-cce25fb/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also rename ngrx-data.module.spec
please?
@timdeschryver renamed in b03eb87. |
#1767 is merged now, so you'll need to rebase on master and update the overview page also. |
Preview docs changes for b03eb87 at https://previews.ngrx.io/pr1780-b03eb87/ |
b03eb87
to
7500dc0
Compare
@brandonroberts rebased. Updated data overview page to reflect code renaming in 7500dc0. Should I update the term "NgRx Data" to "Entity Data" on the overview page as well? |
We still want to refer to it as NgRx Data, with EntityData for usage |
Preview docs changes for 7500dc0 at https://previews.ngrx.io/pr1780-7500dc0/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #1777
What is the new behavior?
To stay consistent across modules, the following was renamed:
NgrxDataModule
->EntityDataModule
NgrxDataModuleWithoutEffects
->EntityDataModuleWithoutEffects
NgrxDataModuleConfig
->EntityDataModuleConfig
Does this PR introduce a breaking change?
Other information