-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add features and migrations #1776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there another feature that needs to be added?
Should we provide more information to the new features, or is it sufficient to point to the docs?
|
||
### `META_REDUCERS` token | ||
- [@ngrx/data](): the [angular-ngrx-data](https://github.com/johnpapa/angular-ngrx-data) library by John Papa and Ward Bell is now an official part of NgRx and can be installed with `npm install @ngrx/data` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once #1767 is merged, we can point to the docs. (build is failing at the moment because the url does not exist yet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just point people to the blog post and keep the migration guide for breaking changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea, we go a little deeper in the blog post, so it's probably better to just point to it 👍
- [`strictImmutability`](/guide/store/configuration/runtime-checks#strictimmutability): verifies that the state and actions aren't being mutated | ||
- [`strictStateSerializability`](/guide/store/configuration/runtime-checks#strictstateserializability): verifies if the state is serializable | ||
- [`strictActionSerializability`](/guide/store/configuration/runtime-checks#strictactionserializability): verifies if the actions are serializable | ||
- [mock selectors](): mock selectors for a fully isolated unit test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on #1761
|
||
### `META_REDUCERS` token | ||
- [@ngrx/data](): the [angular-ngrx-data](https://github.com/johnpapa/angular-ngrx-data) library by John Papa and Ward Bell is now an official part of NgRx and can be installed with `npm install @ngrx/data` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just point people to the blog post and keep the migration guide for breaking changes?
Co-Authored-By: timdeschryver <[email protected]>
Preview docs changes for a2f9c9b at https://previews.ngrx.io/pr1776-a2f9c9b/ |
Once the features section is removed, I think everything looks good 👍 . |
What about the |
Add them in #1782 |
Preview docs changes for 51887db at https://previews.ngrx.io/pr1776-51887db/ |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Follow up to #1757 (coming from #1701)
What is the new behavior?
Does this PR introduce a breaking change?
Other information