Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better test coverage #132

Merged
merged 3 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/communication/roundtripper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ func TestRoundTripperRoundTrip(t *testing.T) {
t.Fatalf(`Unexpected error: %v`, err)
}

request.Header.Set("Content-Type", "application/json")
request.Header.Set("x-nginx-loadbalancer-kubernetes", "nlk")

response, err := roundTripper.RoundTrip(request)
if err != nil {
t.Fatalf(`Unexpected error: %v`, err)
Expand Down
31 changes: 31 additions & 0 deletions internal/core/event_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package core

import (
v1 "k8s.io/api/core/v1"
"testing"
)

func TestNewEvent(t *testing.T) {
expectedType := Created
expectedService := &v1.Service{}
expectedPreviousService := &v1.Service{}
expectedNodeIps := []string{"127.0.0.1"}

event := NewEvent(expectedType, expectedService, expectedPreviousService, expectedNodeIps)

if event.Type != expectedType {
t.Errorf("expected Created, got %v", event.Type)
}

if event.Service != expectedService {
t.Errorf("expected service, got %#v", event.Service)
}

if event.PreviousService != expectedPreviousService {
t.Errorf("expected previous service, got %#v", event.PreviousService)
}

if event.NodeIps[0] != expectedNodeIps[0] {
t.Errorf("expected node ips, got %#v", event.NodeIps)
}
}
16 changes: 16 additions & 0 deletions internal/core/upstream_server_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/*
* Copyright (c) 2023 F5 Inc. All rights reserved.
* Use of this source code is governed by the Apache License that can be found in the LICENSE file.
*/

package core

import "testing"

func TestNewUpstreamServer(t *testing.T) {
host := "localhost"
us := NewUpstreamServer(host)
if us.Host != host {
t.Errorf("NewUpstreamServer(%s) = %s; want %s", host, us.Host, host)
}
}
20 changes: 20 additions & 0 deletions internal/probation/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ package probation

import (
"github.com/nginxinc/kubernetes-nginx-ingress/test/mocks"
"github.com/sirupsen/logrus"
"net/http"
"testing"
)

Expand Down Expand Up @@ -51,3 +53,21 @@ func TestHealthServer_HandleFailCheck(t *testing.T) {
t.Errorf("Expected 'Service Not Available', got %v", body)
}
}

func TestHealthServer_Start(t *testing.T) {
server := NewHealthServer()
server.Start()

response, err := http.Get("http://localhost:51031/livez")
if err != nil {
t.Error(err)
}

if response.StatusCode != http.StatusOK {
t.Errorf("Expected status code %v, got %v", http.StatusAccepted, response.StatusCode)
}

logrus.Infof("recevied a response from the probe server: %v", response)
ciroque marked this conversation as resolved.
Show resolved Hide resolved

server.Stop()
ciroque marked this conversation as resolved.
Show resolved Hide resolved
}