Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better test coverage #132

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Better test coverage #132

merged 3 commits into from
Dec 19, 2023

Conversation

ciroque
Copy link
Collaborator

@ciroque ciroque commented Oct 25, 2023

Proposed changes

Add more tests. Non-official goal of 85% test coverage on each and every module.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

- improve RoundTripper coverage
- exclude coverage files from source control
- Test coverage for UpstreamServer
- Test coverage for probation server module
- Test coverage for Event module
- ignore test coverage files
@ciroque ciroque force-pushed the better-test-coverage branch from 34deee6 to 07d1368 Compare December 18, 2023 23:17
@ciroque ciroque marked this pull request as ready for review December 18, 2023 23:19
@ciroque ciroque requested a review from chrisakker as a code owner December 18, 2023 23:19
@ciroque ciroque requested a review from 4141done December 18, 2023 23:19
Copy link
Collaborator

@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐳 👍
Looks good! minor nits and questions but nothing blocking

internal/probation/server_test.go Outdated Show resolved Hide resolved
internal/probation/server_test.go Outdated Show resolved Hide resolved
@ciroque ciroque merged commit 1eac969 into main Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants