-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect Kubernetes distribution platform and version #1651
Collect Kubernetes distribution platform and version #1651
Conversation
Below is manually gathered values of a node's aks: gke: openshift: eks: rancher: k3s: kind: |
Below is manually gathered values of a node’s aks: gke: openshift: eks: rancher: k3s: kind: They are the same except for eks. |
@bjee19 I recommend resolving the conflicts, so that we don't need to do another review after resolving |
a876b83
to
4411df2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1651 +/- ##
==========================================
+ Coverage 85.83% 85.90% +0.06%
==========================================
Files 86 87 +1
Lines 5459 5512 +53
Branches 52 52
==========================================
+ Hits 4686 4735 +49
- Misses 722 724 +2
- Partials 51 53 +2 ☔ View full report in Codecov by Sentry. |
b7758e4
to
57efd63
Compare
E2E testing results by testing on each platform:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few small suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
a929f5a
to
3550249
Compare
Problem: We want to collect the Kubernetes distribution platform and version to ensure NGF works well with the most popular platforms and versions. Solution: Added collection of Kubernetes distribution platform and version.
Problem: We want to collect the Kubernetes distribution platform and version to ensure NGF works well with the most popular platforms and versions.
Solution: Added collection of Kubernetes distribution platform and version.
Testing: Added unit tests. Conducted E2E testing on each of the specified platforms in #1308 to ensure the platform is correctly collected.
Closes #1308
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.