Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Building the Ingress Controller Image doc #1668

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Fix Building the Ingress Controller Image doc #1668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs-web/installation/building-ingress-controller-image.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ We build the image using the make utility and the provided `Makefile`. Let’s c
1. Clone the Ingress Controller repo:
```
$ git clone https://github.com/nginxinc/kubernetes-ingress/
$ cd kubernetes-ingress
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we just do git clone https://github.com/nginxinc/kubernetes-ingress/ --branch v1.11.3 in one line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why not. We do that in a couple of places though, not only here. Would you like to create a PR?
cd is still needed

$ git checkout v1.11.3
```

Expand Down