Fix Building the Ingress Controller Image doc #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
ciarams87
approved these changes
Jun 16, 2021
vepatel
approved these changes
Jun 16, 2021
lucacome
reviewed
Jun 16, 2021
| @@ -26,6 +26,7 @@ We build the image using the make utility and the provided `Makefile`. Let’s c | |||
| 1. Clone the Ingress Controller repo: | |||
| ``` | |||
| $ git clone https://github.com/nginxinc/kubernetes-ingress/ | |||
| $ cd kubernetes-ingress | |||
There was a problem hiding this comment.
can't we just do git clone https://github.com/nginxinc/kubernetes-ingress/ --branch v1.11.3 in one line?
There was a problem hiding this comment.
I don't see why not. We do that in a couple of places though, not only here. Would you like to create a PR?
cd is still needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix Building the Ingress Controller Image doc