Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move check for plus usage endpoint to test-with-plus target (#2902) (#2904) #2908

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

kate-osborn
Copy link
Contributor

@kate-osborn kate-osborn commented Dec 13, 2024

Cherry-pick #2902 and #2904 into release-1.5. I'm combining the commits because the first one was an incomplete fix.

Problem: Functional tests for OSS on forks are failing because the PLUS_USAGE_ENDPOINT isn't set.

Solution: Move check for PLUS_USAGE_ENDPOINT to the test-with-plus target.

@kate-osborn kate-osborn requested a review from a team as a code owner December 13, 2024 19:01
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests labels Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (9c2deea) to head (160d35b).
Report is 1 commits behind head on release-1.5.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.5    #2908   +/-   ##
============================================
  Coverage        89.71%   89.71%           
============================================
  Files              109      109           
  Lines            11091    11091           
  Branches            50       50           
============================================
  Hits              9950     9950           
  Misses            1082     1082           
  Partials            59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kate-osborn kate-osborn force-pushed the chore/cherry-pick-check-for-plus-fix branch from 555f943 to b788a6d Compare December 13, 2024 20:24
Problem: Functional tests for OSS on forks are failing because the PLUS_USAGE_ENDPOINT isn't set.

Solution: Move check for PLUS_USAGE_ENDPOINT to the test-with-plus target.
Problem: #2902 moved check-for-plus-usage-endpoint dependency to the wrong Makefile target which caused the pipelines on main to fail.

Solution: Move check-for-plus-usage-endpoint` dependency to the right target.
@kate-osborn kate-osborn force-pushed the chore/cherry-pick-check-for-plus-fix branch from b788a6d to 160d35b Compare December 13, 2024 21:28
@kate-osborn kate-osborn merged commit 955af30 into release-1.5 Dec 13, 2024
42 checks passed
@kate-osborn kate-osborn deleted the chore/cherry-pick-check-for-plus-fix branch December 13, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants