Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move check for plus usage endpoint to test-with-plus target #2902

Merged

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: Functional tests for OSS on forks are failing because the PLUS_USAGE_ENDPOINT isn't set.

Solution: Move check for PLUS_USAGE_ENDPOINT to the test-with-plus target.

Testing: testing in pipeline on fork

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@kate-osborn kate-osborn requested a review from a team as a code owner December 13, 2024 16:49
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests labels Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (895ce15) to head (2dc6bc4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2902   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files         109      109           
  Lines       11150    11150           
  Branches       50       50           
=======================================
  Hits        10007    10007           
  Misses       1083     1083           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kate-osborn kate-osborn force-pushed the chore/fix-plus-usage-endp-pipeline branch from c7c679b to 2dc6bc4 Compare December 13, 2024 17:10
@kate-osborn kate-osborn merged commit 73ba22b into nginx:main Dec 13, 2024
40 checks passed
kate-osborn added a commit that referenced this pull request Dec 13, 2024
Problem: #2902 moved check-for-plus-usage-endpoint dependency to the wrong Makefile target which caused the pipelines on main to fail.

Solution: Move check-for-plus-usage-endpoint` dependency to the right target.
kate-osborn added a commit that referenced this pull request Dec 13, 2024
Problem: Functional tests for OSS on forks are failing because the PLUS_USAGE_ENDPOINT isn't set.

Solution: Move check for PLUS_USAGE_ENDPOINT to the test-with-plus target.
kate-osborn added a commit that referenced this pull request Dec 13, 2024
Problem: #2902 moved check-for-plus-usage-endpoint dependency to the wrong Makefile target which caused the pipelines on main to fail.

Solution: Move check-for-plus-usage-endpoint` dependency to the right target.
kate-osborn added a commit that referenced this pull request Dec 13, 2024
Problem: Functional tests for OSS on forks are failing because the PLUS_USAGE_ENDPOINT isn't set.

Solution: Move check for PLUS_USAGE_ENDPOINT to the test-with-plus target.
kate-osborn added a commit that referenced this pull request Dec 13, 2024
Problem: #2902 moved check-for-plus-usage-endpoint dependency to the wrong Makefile target which caused the pipelines on main to fail.

Solution: Move check-for-plus-usage-endpoint` dependency to the right target.
kate-osborn added a commit that referenced this pull request Dec 13, 2024
Problem: Functional tests for OSS on forks are failing because the PLUS_USAGE_ENDPOINT isn't set.

Solution: Move check for PLUS_USAGE_ENDPOINT to the test-with-plus target.
kate-osborn added a commit that referenced this pull request Dec 13, 2024
Problem: #2902 moved check-for-plus-usage-endpoint dependency to the wrong Makefile target which caused the pipelines on main to fail.

Solution: Move check-for-plus-usage-endpoint` dependency to the right target.
kate-osborn added a commit that referenced this pull request Dec 13, 2024
…2904) (#2908)

Problem: Functional tests for OSS on forks are failing because the PLUS_USAGE_ENDPOINT isn't set.

Solution: Move check for PLUS_USAGE_ENDPOINT to the test-with-plus target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants