Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/topology spread constraints #2703

Merged
merged 9 commits into from
Oct 23, 2024

Conversation

Robsta86
Copy link
Contributor

Proposed changes

Problem: Currently the helm chart does not allow us to configure topologySpreadConstraints, as mentioned in issue #2662

Solution: Add topologySpreadConstraints option to the helm chart

Testing: Change has been tested by installing the helm chart with both topologySpreadConstraints configured and left empty.

Closes #2662

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

NONE

@Robsta86 Robsta86 requested a review from a team as a code owner October 19, 2024 20:36
Copy link
Contributor

github-actions bot commented Oct 19, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart labels Oct 19, 2024
@Robsta86
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@Robsta86
Copy link
Contributor Author

pre-commit.ci autofix

@sjberman sjberman removed the enhancement New feature or request label Oct 21, 2024
@github-actions github-actions bot added the enhancement New feature or request label Oct 21, 2024
@sjberman sjberman removed the enhancement New feature or request label Oct 23, 2024
@sjberman sjberman enabled auto-merge (squash) October 23, 2024 20:23
@sjberman sjberman merged commit 105a5e3 into nginx:main Oct 23, 2024
47 checks passed
@Robsta86 Robsta86 deleted the feature/topology-spread-constraints branch October 24, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add support for topologySpreadConstraints
3 participants