Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for topologySpreadConstraints #2662

Closed
MikeBlomm opened this issue Oct 8, 2024 · 2 comments · Fixed by #2703
Closed

Add support for topologySpreadConstraints #2662

MikeBlomm opened this issue Oct 8, 2024 · 2 comments · Fixed by #2703
Labels
community enhancement New feature or request helm-chart Relates to helm chart
Milestone

Comments

@MikeBlomm
Copy link

MikeBlomm commented Oct 8, 2024

Is your enhancement request related to a problem? Please describe.
Currently I'm not able to set a topologySpreadConstraints on the nginx pods. This leads to the fact that I can't have finegrained control of the spread over my availability zones.

What would you like to be added:
Support for a topologySpreadConstraints field on the nginx-gateway-fabric Deployment

Why this is needed:
Allow the spread of mutliple availability zones.

@MikeBlomm MikeBlomm added the enhancement New feature or request label Oct 8, 2024
Copy link

nginx-bot bot commented Oct 8, 2024

Hi @MikeBlomm! Welcome to the project! 🎉

Thanks for opening this issue!
Be sure to check out our Contributing Guidelines and the Issue Lifecycle while you wait for someone on the team to take a look at this.

@nginx-bot nginx-bot bot added the community label Oct 8, 2024
@mpstefan mpstefan added the helm-chart Relates to helm chart label Oct 8, 2024
@mpstefan
Copy link
Collaborator

mpstefan commented Oct 8, 2024

Hey @MikeBlomm, thanks for the feedback! Would you be up to creating a PR for this change? As our backlog is now, we'd need to look at next release, meaning it wouldn't be out in an official release until early next year. If we can get this change in before early Nov, we can squeeze it in for 1.5.

Otherwise, the use case makes sense, and we'll throw it in our backlog!

@mpstefan mpstefan added this to the v2.0.0 milestone Oct 8, 2024
@sjberman sjberman modified the milestones: v2.0.0, v1.5.0 Oct 23, 2024
@lucacome lucacome moved this to ✅ Done in NGINX Gateway Fabric Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community enhancement New feature or request helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants