Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated Dockerfile, matched main.nf so that it can work with it #44

Merged
merged 22 commits into from
Mar 2, 2021

Conversation

subwaystation
Copy link
Collaborator

@subwaystation subwaystation commented Feb 24, 2021

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/pangenome branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This PR fixes #36.

  • Update Dockerfile
  • Update the input parameters
  • Update processes to work with the adjusted input parameters
  • Add wfmash as alternative aligner
  • Rename edyeet alignment parameters to alignment wherever possible
  • Let the user decide which aligner to use, default is edyeet
  • Write MAF output into the results folder
  • Write SMOOTHED graph into the results folder
  • Write all CONSENSUS graphs into the result folder
  • Update file namings
  • Update tests
  • Integrate MultiQC
  • Update help message
  • Update README
  • Escalate the publish-dir-mode argument.

@subwaystation
Copy link
Collaborator Author

Some tests are failing, because the current docker image is not checked out. Will correct.

main.nf Show resolved Hide resolved
README.md Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
main.nf Show resolved Hide resolved
@subwaystation
Copy link
Collaborator Author

@Zethson @heuermh I don't understand why the Markdown lintings are failing. The configuration file is set up in a way to ignore lines longer than 80 characters. I am confused.

@subwaystation subwaystation mentioned this pull request Mar 2, 2021
11 tasks
@subwaystation
Copy link
Collaborator Author

@Zethson As discussed with @drpatelh I integrated a workaround until DavidAnson/markdownlint#373 is fixed. #47 is tracking this, too.

Else, all tests that should pass are passing :)

@subwaystation subwaystation requested a review from Zethson March 2, 2021 13:36
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subwaystation subwaystation merged commit 1b380bf into dev Mar 2, 2021
@heuermh heuermh deleted the issue36 branch February 22, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fastify pangenome generation
4 participants