-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap unzip to nf-test (continuation of 5357) #5897
Merged
Merged
Changes from 18 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ed53bcd
unzip stub, nf-test, snap
sateeshperi f0a3e3b
Revert "unzip stub, nf-test, snap"
jennylsmith b0dd086
Reapply "unzip stub, nf-test, snap"
jennylsmith c9e3fa7
added minimal required tests for process and stub
jennylsmith c8ddbc6
added snapshot
jennylsmith 1ed5ef1
simplify snapshot input in stub test
jennylsmith fb6bba0
remove unneeded stub files
jennylsmith 6063fd6
migrate pytest for unzipfiles
jennylsmith 6b487ab
add snapshot file for script block
jennylsmith 08a6c0b
added stub
jennylsmith 3dd8db5
added stub and stub test
jennylsmith 104348e
updated stub snapshot for unzip
jennylsmith af497f1
remove unneeded test config
jennylsmith 096170c
Merge branch 'master' into unzip-nf-test-2
SPPearce 05dfb04
Update snaps and malt
SPPearce d1764f5
Update malt for linting
SPPearce 0631ca4
Fix linting for maltextract
SPPearce 806f782
Merge branch 'master' into unzip-nf-test-2
SPPearce fd70191
Swap test-data paths for malt modules
SPPearce 36795a9
Update modules/nf-core/maltextract/tests/main.nf.test
maxulysse 18d718c
Merge branch 'master' into unzip-nf-test-2
maxulysse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,15 @@ | ||
{ | ||
"version": { | ||
"test_maltextract": { | ||
"content": [ | ||
[ | ||
"versions.yml:md5,4d87de5def1287321effde6545901cf6" | ||
] | ||
], | ||
"meta": { | ||
"nf-test": "0.8.4", | ||
"nextflow": "23.10.0" | ||
}, | ||
"timestamp": "2024-03-19T13:58:17.979106" | ||
}, | ||
"results": { | ||
"content": [ | ||
], | ||
"ScanSummary.txt:md5,209fb35426f6a459db0f4af0dc544b10" | ||
], | ||
"meta": { | ||
"nf-test": "0.8.4", | ||
"nextflow": "23.10.0" | ||
"nextflow": "24.04.2" | ||
}, | ||
"timestamp": "2024-03-19T14:03:56.643826" | ||
"timestamp": "2024-07-01T08:19:20.696046683" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
nextflow_process { | ||
|
||
name "Test Process UNZIP" | ||
script "../main.nf" | ||
process "UNZIP" | ||
|
||
tag "modules" | ||
tag "modules_nfcore" | ||
tag "unzip" | ||
|
||
test("generic [tar] [tar_gz]") { | ||
|
||
when { | ||
process { | ||
""" | ||
input[0] = [ | ||
[ id: 'hello' ], | ||
file(params.modules_testdata_base_path + 'generic/tar/hello.tar.gz', checkIfExists: true) | ||
] | ||
""" | ||
} | ||
} | ||
|
||
then { | ||
assertAll( | ||
{ assert process.success }, | ||
{ assert snapshot(process.out).match() } | ||
) | ||
} | ||
} | ||
|
||
test("generic [tar] [tar_gz] stub") { | ||
|
||
options "-stub" | ||
|
||
when { | ||
process { | ||
""" | ||
input[0] = [ | ||
[ id: 'hello' ], | ||
file(params.modules_testdata_base_path + 'generic/tar/hello.tar.gz', checkIfExists: true) | ||
] | ||
""" | ||
} | ||
} | ||
|
||
then { | ||
assertAll( | ||
{ assert process.success }, | ||
{ assert snapshot(process.out).match() } | ||
) | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
{ | ||
"generic [tar] [tar_gz] stub": { | ||
"content": [ | ||
{ | ||
"0": [ | ||
[ | ||
{ | ||
"id": "hello" | ||
}, | ||
[ | ||
|
||
] | ||
] | ||
], | ||
"1": [ | ||
"versions.yml:md5,52c55ce814e8bc9edc5a6c625ed794b8" | ||
], | ||
"unzipped_archive": [ | ||
[ | ||
{ | ||
"id": "hello" | ||
}, | ||
[ | ||
|
||
] | ||
] | ||
], | ||
"versions": [ | ||
"versions.yml:md5,52c55ce814e8bc9edc5a6c625ed794b8" | ||
] | ||
} | ||
], | ||
"meta": { | ||
"nf-test": "0.8.4", | ||
"nextflow": "24.04.2" | ||
}, | ||
"timestamp": "2024-06-30T19:16:37.11550986" | ||
}, | ||
"generic [tar] [tar_gz]": { | ||
"content": [ | ||
{ | ||
"0": [ | ||
[ | ||
{ | ||
"id": "hello" | ||
}, | ||
[ | ||
"hello.tar:md5,80c66db79a773bc87b3346035ff9593e" | ||
] | ||
] | ||
], | ||
"1": [ | ||
"versions.yml:md5,52c55ce814e8bc9edc5a6c625ed794b8" | ||
], | ||
"unzipped_archive": [ | ||
[ | ||
{ | ||
"id": "hello" | ||
}, | ||
[ | ||
"hello.tar:md5,80c66db79a773bc87b3346035ff9593e" | ||
] | ||
] | ||
], | ||
"versions": [ | ||
"versions.yml:md5,52c55ce814e8bc9edc5a6c625ed794b8" | ||
] | ||
} | ||
], | ||
"meta": { | ||
"nf-test": "0.8.4", | ||
"nextflow": "24.04.2" | ||
}, | ||
"timestamp": "2024-06-30T19:16:25.120242571" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
unzip: | ||
- "modules/nf-core/unzip/**" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
nextflow_process { | ||
|
||
name "Test Process UNZIPFILES" | ||
script "../main.nf" | ||
process "UNZIPFILES" | ||
|
||
tag "modules" | ||
tag "modules_nfcore" | ||
tag "unzipfiles" | ||
|
||
test("generic [tar] [tar_gz]") { | ||
|
||
when { | ||
process { | ||
""" | ||
input[0] = [ | ||
[ id: 'hello' ], | ||
file(params.modules_testdata_base_path + 'generic/tar/hello.tar.gz', checkIfExists: true) | ||
] | ||
""" | ||
} | ||
} | ||
|
||
then { | ||
assertAll( | ||
{ assert process.success }, | ||
{ assert snapshot(process.out).match() } | ||
) | ||
} | ||
} | ||
|
||
test("generic [tar] [tar_gz] stub") { | ||
|
||
options "-stub" | ||
|
||
when { | ||
process { | ||
""" | ||
input[0] = [ | ||
[ id: 'hello' ], | ||
file(params.modules_testdata_base_path + 'generic/tar/hello.tar.gz', checkIfExists: true) | ||
] | ||
""" | ||
} | ||
} | ||
|
||
then { | ||
assertAll( | ||
{ assert process.success }, | ||
{ assert snapshot(process.out).match() } | ||
) | ||
} | ||
} | ||
|
||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the input for unzip on line 19 is a
739.0 MiB
zip...I'm guessing that's why the tests are failing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cf #4801