-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stub and nf-test for malt/run & malt/build #4801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 🚀
Those tests should be fixed though 😁 |
Ah that was the last thing: tests can't run at all currently because the website the reference db file it needs is down (I will put back the URL)... but I'll need to set these tests to just running stub at the moment :( |
Cool :p |
I'll need to then comment out the tests and leave just stubs (with the ownloaded file just as a |
you could consider adding test reference to nf-core modules test datasets: https://nf-co.re/docs/contributing/test_data_guidelines#modules. We want to avoid reaching out to external sources, especially if they aren't reliably available. |
OK given the last maintainers meeting and the plan to possible mirror the test data repo to AWS I've done that with this file, also as I will have to use it for a new pipeline too... |
* Add stubs to malt/run and malt/build * Auto-migrate run and build * First pass of nf-test runs for build * Get working MALT/build snapshot * Update MALT/RUN tests, rma6 cahnnel not working * New version of assert * Back to BCL convert example * Get MALT/RUN tests working - thanks Maxime and Nicolas! * Put the URL for the database, for when it starts working... * Temporarily skip CI tests for MALT/RUN and MALT/BUILD * Use a nf-core copy of db file * Fix linting and remove debugging mem specification
PR checklist
Closes #XXX
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware