Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stub and nf-test for malt/run & malt/build #4801

Merged
merged 14 commits into from
Jan 28, 2024
Merged

Add stub and nf-test for malt/run & malt/build #4801

merged 14 commits into from
Jan 28, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 25, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@jfy133 jfy133 requested a review from a team as a code owner January 25, 2024 09:36
@jfy133 jfy133 requested a review from ahvigil January 25, 2024 09:36
@jfy133 jfy133 marked this pull request as draft January 25, 2024 09:36
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@jfy133 jfy133 marked this pull request as ready for review January 26, 2024 13:29
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚀

@nvnieuwk
Copy link
Contributor

Those tests should be fixed though 😁

@jfy133
Copy link
Member Author

jfy133 commented Jan 26, 2024

Ah that was the last thing: tests can't run at all currently because the website the reference db file it needs is down (I will put back the URL)... but I'll need to set these tests to just running stub at the moment :(

@nvnieuwk
Copy link
Contributor

Cool :p

@jfy133
Copy link
Member Author

jfy133 commented Jan 26, 2024

I'll need to then comment out the tests and leave just stubs (with the ownloaded file just as a [])

@ahvigil
Copy link
Contributor

ahvigil commented Jan 26, 2024

you could consider adding test reference to nf-core modules test datasets: https://nf-co.re/docs/contributing/test_data_guidelines#modules. We want to avoid reaching out to external sources, especially if they aren't reliably available.

@jfy133
Copy link
Member Author

jfy133 commented Jan 28, 2024

you could consider adding test reference to nf-core modules test datasets: https://nf-co.re/docs/contributing/test_data_guidelines#modules. We want to avoid reaching out to external sources, especially if they aren't reliably available.

Agreed, unfortunately the file is too large :(

OK given the last maintainers meeting and the plan to possible mirror the test data repo to AWS I've done that with this file, also as I will have to use it for a new pipeline too...

@jfy133 jfy133 added this pull request to the merge queue Jan 28, 2024
Merged via the queue into nf-core:master with commit 7d3bac6 Jan 28, 2024
22 checks passed
@jfy133 jfy133 deleted the nftest-stub-malt branch January 28, 2024 09:45
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
* Add stubs to malt/run and malt/build

* Auto-migrate run and build

* First pass of nf-test runs for build

* Get working MALT/build snapshot

* Update MALT/RUN tests, rma6 cahnnel not working

* New version of assert

* Back to BCL convert example

* Get MALT/RUN tests working - thanks Maxime and Nicolas!

* Put the URL for the database, for when it starts working...

* Temporarily skip CI tests for MALT/RUN and MALT/BUILD

* Use a nf-core copy of db file

* Fix linting and remove debugging mem specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants