Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port controlfreec-freec to nf-test #5398

Merged
merged 8 commits into from
Mar 28, 2024
Merged

port controlfreec-freec to nf-test #5398

merged 8 commits into from
Mar 28, 2024

Conversation

famosab
Copy link
Contributor

@famosab famosab commented Mar 26, 2024

PR checklist

Closes #XXX
Relates to #3937

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@famosab famosab marked this pull request as ready for review March 27, 2024 09:35
@famosab famosab requested review from FriederikeHanssen and a team as code owners March 27, 2024 09:35
@maxulysse maxulysse added this pull request to the merge queue Mar 28, 2024
@maxulysse maxulysse removed this pull request from the merge queue due to a manual request Mar 28, 2024
@maxulysse maxulysse enabled auto-merge March 28, 2024 11:07
@maxulysse maxulysse added this pull request to the merge queue Mar 28, 2024
Merged via the queue into nf-core:master with commit 7b5827a Mar 28, 2024
11 checks passed
jvfe added a commit that referenced this pull request Mar 28, 2024
@jvfe
Merge branch 'master' into nf-test_phispy
2d824ce 
* master:
  Added new module for Toulligqc (#5131)
  Make `mosdepth` stub use `gzip` for `.gz` files (#5410)
  Update hmmsearch to 3.4 (#5408)
  port `controlfreec-makegraph` to nf-test (#5393)
  port `controlfreec-freec` to nf-test (#5398)
  port `controlfreec-assesssignificance` to nf-test (#5396)
  port `controlfreec-makegraph2` to nf-test (#5392)
  new module: crabz (#5351)
@SPPearce SPPearce mentioned this pull request May 2, 2024
Closed
14 tasks
@famosab famosab deleted the controlfreec-freec-3 branch May 15, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@famosab @maxulysse