Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align versioning across tests and config #87

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix: align versioning across tests and config #87

merged 2 commits into from
Oct 31, 2024

Conversation

znorgaard
Copy link
Collaborator

Nextflow 24.04.0 is when the resourceLimits directive was introduced. Github actions on older versions will fail because they won't respect these resource limits.
https://github.com/nextflow-io/nextflow/blob/0140f954fdcfd0d03c8d568e61b193f0db067bf6/changelog.txt#L252-L257

24.04.2 is the version originally used in the template update PR.
https://github.com/nf-core/fastquorum/blob/5d7af8bd61df3a0e20ab2cd6782530ebeea0aada/nextflow.config#L243C5-L243C20

This PR reverts #86 and further raises the version that was raised in #85

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fastquorum branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @znorgaard,

It looks like this pull-request is has been made against the nf-core/fastquorum master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/fastquorum dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@znorgaard znorgaard changed the base branch from master to dev October 31, 2024 15:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit bf5f98e

+| ✅ 194 tests passed       |+
#| ❔   8 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-31 15:48:46

@znorgaard znorgaard merged commit edf6172 into dev Oct 31, 2024
9 checks passed
@znorgaard znorgaard deleted the zn_fix_versioning branch October 31, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

Assignees

@SPPearce SPPearce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@znorgaard @SPPearce