Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: raise minimum version #85

Merged
merged 2 commits into from
Oct 28, 2024
Merged

chore: raise minimum version #85

merged 2 commits into from
Oct 28, 2024

Conversation

znorgaard
Copy link
Collaborator

The nf-core template update switches to nf-schema instead of nf-validation which requires nextflow>=23.10.0. Testing on 23.04.0 is expected to fail (and did fail on dev ci checks).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fastquorum branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Oct 24, 2024

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 4495e3e

+| ✅ 194 tests passed       |+
#| ❔   8 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-24 22:43:05

@znorgaard znorgaard marked this pull request as ready for review October 24, 2024 22:49
@znorgaard znorgaard merged commit ff69546 into dev Oct 28, 2024
9 checks passed
@znorgaard znorgaard deleted the zn_nf_version_update branch October 28, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants