-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kraken2 empty fastq resulting in no output file fix #898
Conversation
Markdown linting is failingTo keep the code consistent with lots of contributors, we run automated code consistency checks.
Once you push these changes the test should pass, and you can hide this comment 👍 We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help! Thanks again for your contribution! |
YAML linting is failingTo keep the code consistent with lots of contributors, we run automated code consistency checks.
Once you push these changes the test should pass, and you can hide this comment 👍 We highly recommend setting up yaml-lint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help! Thanks again for your contribution! |
This PR is against the
|
main.nf
Outdated
@@ -702,7 +703,7 @@ process fastqc { | |||
""" | |||
} else { | |||
""" | |||
fastqc -q $r1 | |||
fastqc -t ${task.cpus} -q $r1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure I saw this bit in another PR already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, branched off that PR acceidnetly. Will disappear once that PR is merged in :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added docs |
PR checklist
Closes #897
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).