Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in UnifiedGenotyper IndelRealigner command #707

Merged
merged 5 commits into from
Mar 20, 2021

Conversation

IdoBar
Copy link
Contributor

@IdoBar IdoBar commented Mar 20, 2021

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

jfy133 and others added 2 commits March 16, 2021 16:22
Changed {samplenane} to {samplename} (line 2337)
@github-actions
Copy link

Hi @IdoBar,

It looks like this pull-request is has been made against the IdoBar/eager master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the IdoBar/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, well spotted!

@apeltzer apeltzer changed the base branch from master to dev March 20, 2021 10:11
CHANGELOG.md Outdated Show resolved Hide resolved
@jfy133 jfy133 merged commit 7296290 into nf-core:dev Mar 20, 2021
@jfy133 jfy133 mentioned this pull request Apr 6, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants