Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Colour chem validation #694

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Fix Colour chem validation #694

merged 2 commits into from
Mar 12, 2021

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Mar 10, 2021 •
edited
Loading

#693 reported that no colour chemistry validation occured. It actually did exist, I just mixed up groovy operators 😅 . This fixes that (and is tested).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 requested a review from a team March 10, 2021 15:57
apeltzer
apeltzer approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just the failing CI ?

@jfy133 jfy133 merged commit a819990 into dev Mar 12, 2021
@jfy133 jfy133 deleted the colour-chem-validation branch March 12, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfy133 @apeltzer