Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SH files for unite9 #800

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Fix SH files for unite9 #800

merged 3 commits into from
Nov 21, 2024

Conversation

jtangrot
Copy link
Contributor

The files used to assign SH for UNITE 9.0 are missing some taxonomies due to an update of the PlutoF API that partially broke the scripts used. This PR gives links to the new, corrected files.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Did I understand right that the files are identical, just retrieved from a different location? Or are the files actually different? If the latter, then it might be good to explain that a little more in the CHANGELOG?

@jtangrot
Copy link
Contributor Author

They are actually different, the old files were missing some taxonomies. I tried to explain slightly more in changelog.

@d4straub
Copy link
Collaborator

Ah great thanks!

@jtangrot jtangrot merged commit 3f3cba5 into nf-core:dev Nov 21, 2024
31 checks passed
@jtangrot jtangrot deleted the fix_unite9 branch November 21, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants