Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/pathogens: Add tiles for all pathogens #1034

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Oct 1, 2024

preview

Description of proposed changes

See linked issue and commit messages

Related issue(s)

Closes #1033

Checklist

@victorlin victorlin self-assigned this Oct 1, 2024
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-victorlin--8r2s7q October 1, 2024 00:12 Inactive
@victorlin victorlin force-pushed the victorlin/repurpose-showcase branch from 3050a4c to 29bf64b Compare October 1, 2024 23:01
@victorlin victorlin temporarily deployed to nextstrain-s-victorlin--8r2s7q October 1, 2024 23:01 Inactive
@victorlin victorlin marked this pull request as ready for review October 1, 2024 23:02
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Nextclade tile?

I think it would make sense to include a "Nextclade" tile to showcase all the top level categories of pathogen builds.

The component was previously named "showcase" when the number of tiles
shown was limited by viewport width. With the expandable tiles feature,
this is no longer the case and the component can be repurposed as a
"table of contents" or index to show all possible tiles.
The order in the YAML file is mostly arbitrary. Name is also the default
sort for the resource listing on the same page.
@victorlin victorlin force-pushed the victorlin/repurpose-showcase branch from 29bf64b to 7bda4ea Compare October 3, 2024 22:43
@victorlin victorlin temporarily deployed to nextstrain-s-victorlin--8r2s7q October 3, 2024 22:43 Inactive
@victorlin
Copy link
Member Author

Added Nextclade tile as SARS-CoV-2 (Nextclade):

image

@victorlin victorlin merged commit 7617c38 into master Oct 4, 2024
7 checks passed
@victorlin victorlin deleted the victorlin/repurpose-showcase branch October 4, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/pathogens: Add tiles for all pathogens
3 participants