Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links after migrating to read the docs #14

Closed
Tracked by #29
eharkins opened this issue Sep 25, 2020 · 2 comments
Closed
Tracked by #29

Fix links after migrating to read the docs #14

eharkins opened this issue Sep 25, 2020 · 2 comments
Assignees
@genehack

Comments

@eharkins
Copy link
Contributor

There are many links which will not work or not make sense after migrating everything to be hosted on the same domain.

Here are some examples:
@eharkins
Copy link
Contributor Author

Hopefully redirects will cover most of this, but there might be some links in nextstrain repo readmes that we will want to change, or at least the language around the links may change, e.g. https://github.com/nextstrain/.github/blob/master/CONTRIBUTING.md#contribute-documentation

eharkins added a commit that referenced this issue Oct 22, 2020
@eharkins
fix sharing-data 404s; #14;
d4e79e6 
this page was removed in #30
@eharkins eharkins mentioned this issue Nov 7, 2020
Merged
@genehack genehack self-assigned this Aug 5, 2024
@genehack genehack mentioned this issue Aug 5, 2024
Closed
1 task
genehack added a commit to nextstrain/auspice that referenced this issue Aug 5, 2024
@genehack
Fix two broken links [nextstrain/docs.nextstrain.org#14]
6af016a
genehack added a commit to nextstrain/augur that referenced this issue Aug 5, 2024
@genehack
Fix broken links [nextstrain/docs.nextstrain.org#14]
15fab9e 
* Link to "community page on site" rather than "community section on
  front page"
* Update colorbrewer link to HTTPS
* Update link to Zika reference GenBank file to current location in
  repo
genehack added a commit to nextstrain/augur that referenced this issue Aug 5, 2024
@genehack
Remove link to example that was removed from the repo [nextstrain/doc…
d513f01 
…s.nextstrain.org#14]
genehack added a commit that referenced this issue Aug 5, 2024
@genehack
Pin a minimum Sphinx version in Conda env file [#14]
e4330af 
v7.1 is the version where `linkcheck_anchors_ignore_for_url` was
added; we need this option so we can tell the linkchecker to ignore
GitHub's fake anchors.
genehack added a commit that referenced this issue Aug 5, 2024
@genehack
Add link checker related options to conf.py [#14]
40f5262
genehack added a commit that referenced this issue Aug 5, 2024
@genehack
Use correct hostname for discussion site [#14]
c46f315
genehack added a commit that referenced this issue Aug 5, 2024
@genehack
Fix link to RSV dataset [#14]
7f7e432
genehack added a commit that referenced this issue Aug 5, 2024
@genehack
Fix links to files in measles repo [#14]
97d94b8
genehack added a commit that referenced this issue Aug 5, 2024
@genehack
Link to appropriate(?) section of RTD site [#14]
9399a74
genehack added a commit that referenced this issue Aug 5, 2024
@genehack
Link to currently used anchor on Conda site [#14]
71aea95
genehack added a commit that referenced this issue Aug 5, 2024
@genehack
Link to correct PNAS URL [#14]
522cf59 
We're still blocked from validating this (which is why it ends up in
the exclude list in conf.py) but this is what the old URL was
redirecting to.
genehack added a commit that referenced this issue Aug 5, 2024
@genehack
Update CDC anchors to current [#14]
69b6507 
N.b., for the flu link, there are no longer anchors present in the
page, so I removed it completely. Measles did still have an
appropriate anchor to link to.
This was referenced Aug 5, 2024
Merged
Merged
Merged
Merged
genehack added a commit to nextstrain/augur that referenced this issue Aug 6, 2024
@genehack
Fix broken links [nextstrain/docs.nextstrain.org#14]
1c59306 
* Link to "community page on site" rather than "community section on
  front page"
* Update colorbrewer link to HTTPS
* Update link to Zika reference GenBank file to current location in
  repo
* Update link to example that was removed from the repo to point to
  last version before deletion
genehack added a commit to nextstrain/augur that referenced this issue Aug 6, 2024
@genehack
Change all master elements in Github URLs to - [nextstrain/docs.n…
c5fc5cc 
…extstrain.org#14]

Feels like a good time to get all these cleaned up…
genehack added a commit to nextstrain/auspice that referenced this issue Aug 6, 2024
@genehack
Fix two broken links [nextstrain/docs.nextstrain.org#14]
77b9123
genehack added a commit that referenced this issue Aug 6, 2024
@genehack
Add link checker related options to conf.py [#14]
19c2a02
genehack added a commit that referenced this issue Aug 6, 2024
@genehack
Use correct hostname for discussion site [#14]
15be84e
genehack added a commit that referenced this issue Aug 6, 2024
@genehack
Fix link to RSV dataset [#14]
c6375e5
genehack added a commit that referenced this issue Aug 6, 2024
@genehack
Fix links to files in measles repo [#14]
1728869
genehack added a commit that referenced this issue Aug 6, 2024
@genehack
Link to appropriate(?) section of RTD site [#14]
d2352d8
genehack added a commit that referenced this issue Aug 6, 2024
@genehack
Link to currently used anchor on Conda site [#14]
4a62f63
genehack added a commit that referenced this issue Aug 6, 2024
@genehack
Link to correct PNAS URL [#14]
5dd7eaa 
We're still blocked from validating this (which is why it ends up in
the exclude list in conf.py) but this is what the old URL was
redirecting to.
genehack added a commit that referenced this issue Aug 6, 2024
@genehack
Update CDC anchors to current [#14]
3ff6ae8 
N.b., for the flu link, there are no longer anchors present in the
page, so I removed it completely. Measles did still have an
appropriate anchor to link to.
genehack added a commit to nextstrain/auspice that referenced this issue Aug 6, 2024
@genehack
Merge pull request #1805 from nextstrain/fix-broken-links-14
84a1548 
Fix two broken links [nextstrain/docs.nextstrain.org#14]
genehack added a commit that referenced this issue Aug 6, 2024
@genehack
Merge pull request #218 from nextstrain/fix-broken-links-14
2804377 
Fix broken links [#14]
genehack added a commit to nextstrain/augur that referenced this issue Aug 6, 2024
@genehack
Fix broken links [nextstrain/docs.nextstrain.org#14]
f8afae3 
* Link to "community page on site" rather than "community section on
  front page"
* Update colorbrewer link to HTTPS
* Update link to Zika reference GenBank file to current location in
  repo
* Update link to example that was removed from the repo to point to
  last version before deletion
genehack added a commit to nextstrain/augur that referenced this issue Aug 6, 2024
@genehack
Change all master elements in Github URLs to - [nextstrain/docs.n…
cc01063 
…extstrain.org#14]

Feels like a good time to get all these cleaned up…
genehack added a commit to nextstrain/augur that referenced this issue Aug 6, 2024
@genehack
Merge pull request #1568 from nextstrain/fix-broken-links-14
dbc9d4c 
Fix broken links [nextstrain/docs.nextstrain.org#14]
genehack added a commit to nextstrain/auspice that referenced this issue Aug 6, 2024
@genehack
missed one broken link [nextstrain/docs.nextstrain.org#14]
f58a2c8
genehack added a commit that referenced this issue Aug 6, 2024
@genehack
Add colorbrewer2.org to the "check the link, ignore the anchor" list [#…
931e3e3 
…14]
genehack added a commit that referenced this issue Aug 6, 2024
@genehack
Fix one missed broken link [#14]
faae26d 
Also tweak the language around it a tiny bit to match reality.
This was referenced Aug 6, 2024
Merged
Merged
genehack added a commit to nextstrain/auspice that referenced this issue Aug 6, 2024
@genehack
missed one broken link [nextstrain/docs.nextstrain.org#14]
cb4736a
genehack added a commit to nextstrain/auspice that referenced this issue Aug 6, 2024
@genehack
Merge pull request #1806 from nextstrain/more-broken-links-14
ca3dc6f 
missed one broken link [nextstrain/docs.nextstrain.org#14]
genehack added a commit that referenced this issue Aug 7, 2024
@genehack
Merge pull request #219 from nextstrain/more-broken-links-14
498cf14 
More broken links [#14]
@genehack
Copy link
Contributor

genehack commented Aug 7, 2024

As make linkcheck now runs without error on docs.nextstrain.org:master, I am closing this issue.

@genehack genehack closed this as completed Aug 7, 2024
genehack added a commit that referenced this issue Aug 13, 2024
@genehack
Anchor regexes and escape potential metachars [#14]
11eee83 
Also add note that the underlying code in the linkchecker uses
`re.match()` to evaluate the regular expression, so there's already an
implicit start of string anchor in effect, and something like
`r'google'` will _NOT_ match anything.
genehack added a commit that referenced this issue Aug 15, 2024
@genehack
Merge pull request #220 from nextstrain/anchor-regexes-14
b744535 
Anchor regexes and escape potential metachars [#14]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@genehack genehack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@genehack @eharkins