Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS 10.14 cannot install any versions after 20230615T171309Z #38

Closed
joverlee521 opened this issue Jul 25, 2023 · 5 comments
Closed

macOS 10.14 cannot install any versions after 20230615T171309Z #38

joverlee521 opened this issue Jul 25, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@joverlee521
Copy link
Contributor

Found out that I could not install any versions after 20230615T171309Z while investigating nextstrain/cli#300.

Traced this to the update of nodejs in 20230628T211222Z from version 18.15.0 to 18.16.1.

The update of nodejs in conda-forge/nodejs-feedstock#310 included bumping the minimum macOS version to 10.15.

@jameshadfield
Copy link
Member

Nothing seems obvious in the node changelog why it coudn't be build on MacOS 10.14, but conda-forge does indeed bump the minimum version to 10.15.

I presume this doesn't include new docker containers @joverlee521, or do they fail on 10.14 as well?

I think we have to draw a line somewhere regarding how much we invest in compatibility for the cross-product of {runtimes, nextstrain/augur/auspice versions, OS/arch versions}, and I would be tempted to categorise this as "won't fix".

@tsibley
Copy link
Member

tsibley commented Jul 25, 2023

The conda-forge recipe bump on macOS version appears at a glance to be to make the newer C11/C++17 aligned_alloc() function available via a paired Clang version bump. See the error that was quoted.

macOS 10.14 went unsupported by Apple in October 2021. @joverlee521 It's probably time to upgrade since unsupported means no security updates!

@joverlee521
Copy link
Contributor Author

joverlee521 commented Jul 26, 2023

Totally agree that we have to draw the line somewhere. I'm fine with closing this issue as "won't fix"!

I wonder if we want to add run_constrained in our recipe.yaml similar to what nodejs has in their recipe.

This at least provides a nice error message when I try to install nodejs with mamba:

$  mamba install -c conda-forge nodejs==18.16.1 --quiet
Could not solve for environment specs
The following packages are incompatible
├─ __osx is requested and can be installed;
└─ nodejs 18.16.1  is not installable because it requires
   └─ __osx >=10.15 , which conflicts with any installable versions previously reported.

Although, the error message is not as clear when I try to install with micromamba

v1.1.0 (version of micromamba we are using in Nextstrain CLI)

$ micromamba install -c conda-forge nodejs==18.16.1 --quiet
critical libmamba Cannot strip file extension from: __osx

v1.4.9 (latest version of micromamba)

$ micromamba install -c conda-forge nodejs==18.16.1 --quiet
critical libmamba Could not set URL (code: 14 - url = @)

@tsibley
Copy link
Member

tsibley commented Jul 26, 2023

"not as clear" is quite an understatement…

@joverlee521 joverlee521 moved this from New to Backlog in Nextstrain planning (archived) Aug 9, 2023
@tsibley
Copy link
Member

tsibley commented Sep 15, 2023

Is this a "won't fix" situation?

@joverlee521 joverlee521 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2023
tsibley added a commit to nextstrain/cli that referenced this issue Sep 15, 2023
This our intent and expectation, and it's good to be explicit about it.
It may surface more installation issues, such as the one we observed in
monkeypox CI¹ with the latest version not being installable, but
obscuring those or surfacing them later on is _probably_ worse than
addressing them head on earlier.  This change will mean that any macOS
10.14 users, if any, would have to use

    NEXTSTRAIN_CONDA_BASE_PACKAGE="nextstrain-base ==20230615T171309Z"

since newer versions aren't installable for them.²

This behaviour also parallels update's behaviour since "runner.conda:
Explicitly specify a nextstrain-base version when updating" (d6e4f2b).
It was an oversight (on my part) to not use the same behaviour during
setup, but at the time I was focused on fixing an update bug.

¹ <nextstrain/mpox#177>
² <nextstrain/conda-base#38>
tsibley added a commit to nextstrain/cli that referenced this issue Sep 15, 2023
This our intent and expectation, and it's good to be explicit about it.
It may surface more installation issues, such as the one we observed in
monkeypox CI¹ with the latest version not being installable, but
obscuring those or surfacing them later on is _probably_ worse than
addressing them head on earlier.  This change will mean that any macOS
10.14 users, if any, would have to use

    NEXTSTRAIN_CONDA_BASE_PACKAGE="nextstrain-base ==20230615T171309Z"

since newer versions aren't installable for them.²

This behaviour also parallels update's behaviour since "runner.conda:
Explicitly specify a nextstrain-base version when updating" (d6e4f2b).
It was an oversight (on my part) to not use the same behaviour during
setup, but at the time I was focused on fixing an update bug.

Related-to: <nextstrain/conda-base#41>
Related-to: <nextstrain/conda-base#42>

¹ <nextstrain/mpox#177>
² <nextstrain/conda-base#38>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

3 participants