Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 1073; set up arrow height #1074

Merged
merged 1 commit into from
Apr 19, 2020
Merged

fix 1073; set up arrow height #1074

merged 1 commit into from
Apr 19, 2020

Conversation

eharkins
Copy link
Contributor

Fix #1073

@jameshadfield jameshadfield temporarily deployed to auspice-1073-up-arrow-smczki6b April 17, 2020 00:26 Inactive
@eharkins
Copy link
Contributor Author

Closing this for now because #1073 actually doesn't reproduce on nextstrain.org. My mistake!

@eharkins eharkins closed this Apr 17, 2020
@jameshadfield
Copy link
Member

This'll be (I think) introduced in #1041 which is in auspice master but not auspice 2.12.0 which nextstrain.org is using

@jameshadfield jameshadfield reopened this Apr 17, 2020
@jameshadfield jameshadfield temporarily deployed to auspice-1073-up-arrow-rvd0mqpq April 17, 2020 00:59 Inactive
@eharkins
Copy link
Contributor Author

Yep @jameshadfield, checking out 5562785 seems to be the earliest this issue is introduced. My fix here does seem to prevent the issue from happening.

@jameshadfield jameshadfield merged commit 2c8749a into master Apr 19, 2020
@jameshadfield jameshadfield deleted the 1073-up-arrow branch April 19, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameshadfield jameshadfield jameshadfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

handUp arrow (div) is clickable from any height on page
2 participants
@eharkins @jameshadfield