Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handUp arrow (div) is clickable from any height on page #1073

Closed
eharkins opened this issue Apr 17, 2020 · 0 comments · Fixed by #1074
Closed

handUp arrow (div) is clickable from any height on page #1073

eharkins opened this issue Apr 17, 2020 · 0 comments · Fixed by #1074
Assignees
Labels
bug Something isn't working

Comments

@eharkins
Copy link
Contributor

eharkins commented Apr 17, 2020

Current Behavior
The narratives up arrow is clickable from any height on the page, and covers other links up in certain areas.

Expected behavior
The up arrow should only be clickable when hovering over its icon.

How to reproduce
Steps to reproduce the current behavior:

  1. Go to http://nextstrain.org/narratives/ncov/sit-rep/2020-04-10?n=1
  2. Hover over the up arrow and trace your mouse down, keeping it in the same place in the lateral dimension, so that the mouse keeps showing the link style cursor hand.
  3. You can click anywhere on the page within the lateral bounds of the up arrow (excluding clicking on the down arrow since it is inserted into the DOM on the same z-axis but after the up arrow - I think this is how it works) and it will go to the previous page.

Possible solution
Add an explicit CSS heigh to the up arrow div (and thereby the down arrow div too since they are created programmatically with the same function).

Your environment: if browsing Nextstrain online

  • Operating system: macOS High Sierra 10.13.4
  • Browser: Chrome 80.0.3987.149 (Official Build) (64-bit)

Additional context
image

@eharkins eharkins added the bug Something isn't working label Apr 17, 2020
@eharkins eharkins self-assigned this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant