In Google Batch, add missed warning #5279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
See also this warning in the docs: Lines 157 to 160 in bf0cd32 |
When both boot disk image and instance template are specified, the instance template gets priority, as with many other options covered by instance templates. Warn the user in this case. This was missed in #5268. Signed-off-by: Siddhartha Bagaria <[email protected]>
siddharthab
force-pushed
the
gcp-boot-image
branch
from
0d13853
to
d848010
Compare
Done. Thanks. |
bentsherman
approved these changes
Sep 3, 2024
pditommaso
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both boot disk image and instance template are specified, the
instance template gets priority, as with many other options covered by
instance templates. Warn the user in this case.
This was missed in #5268.
Signed-off-by: Siddhartha Bagaria [email protected]