In Google Batch, support user specified boot images

[siddharthab]

The default boot image is batch-cos, but it may not be desired in all
situations. In particular, there is an ongoing issue in which the
batch-cos image does not retry pulling a docker image if there was a
network issue. The user may also have some some other configuration
pre-configured in their custom boot image.

Signed-off-by: Siddhartha Bagaria [email protected]

[netlify]

✅ Deploy Preview for nextflow-docs-staging canceled.

Name	Link
🔨 Latest commit	5fd7618
🔍 Latest deploy log	https://app.netlify.com/sites/nextflow-docs-staging/deploys/66d6b4fe0f95e600082c5ebc

[pditommaso]

Thanks for this PR. It would be useful to add some unit tests to validate the changes

[siddharthab]

Thanks for this PR. It would be useful to add some unit tests to validate the changes

Added a very basic unit test; tested with ./gradlew ':plugins:nf-google:test'. Please let me know if you would like more.

[pditommaso]

all fine. thanks for this contribution

[bentsherman]

@siddharthab do you know if the boot image can be specified in an instance template? if so, we should add a warning that the boot image option you added will be overridden by the instance template if one is used:

nextflow/plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchTaskHandler.groovy

Lines 299 to 318 in bf0cd32

	if( task.config.getMachineType()?.startsWith('template://') ) {
	if( task.config.getAccelerator() )
	log.warn1 'Process directive `accelerator` ignored because an instance template was specified'
	if( task.config.getDisk() )
	log.warn1 'Process directive `disk` ignored because an instance template was specified'
	if( executor.config.cpuPlatform )
	log.warn1 'Config option `google.batch.cpuPlatform` ignored because an instance template was specified'
	if( executor.config.preemptible )
	log.warn1 'Config option `google.batch.premptible` ignored because an instance template was specified'
	if( executor.config.spot )
	log.warn1 'Config option `google.batch.spot` ignored because an instance template was specified'
	instancePolicyOrTemplate
	.setInstallGpuDrivers( executor.config.getInstallGpuDrivers() )
	.setInstanceTemplate( task.config.getMachineType().minus('template://') )
	}

[siddharthab]

if so, we should add a warning

You are right. I missed the warnings section. Will send another PR.