Force the user to scroll text to be able to accept the TOS #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GretaD
force-pushed
the
add/force-scroll-tos
branch
from
e74290d
to
9eddb5a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
GretaD
force-pushed
the
add/force-scroll-tos
branch
2 times, most recently
from
0a12fe1
to
b1d2856
Compare
GretaD
force-pushed
the
add/force-scroll-tos
branch
from
b1d2856
to
8dd3ef4
Compare
There was a problem hiding this comment.
Looks good to me. I had a look at the code but did not test it yet.
https://github.com/nextcloud/terms_of_service/blob/master/src/Registration.vue#L27-L39 also contains a ModalContent. I don't know where the Registration component is shown - but I think it will also need to be adjusted as otherwise the isScrollComplete will default to false and it will be impossible to submit the TOS.
GretaD
force-pushed
the
add/force-scroll-tos
branch
from
25dcddf
to
7c79011
Compare
|
/compile amend |
Signed-off-by: greta <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
add/force-scroll-tos
branch
from
7c79011
to
cb48ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.16.07.2024.13.58.30.webm